Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes rules_haskell use node 16 as mentioned in issue #1742.
rules_nodejs
is updated so that node 16 is now the default.nodejs-16_x
is now used instead of the defaultnodejs
.rules_nodejs update.
The way to use rules_nodejs 5.0.0 with nix changed quite a bit:
_nixpkgs_nodejs
macro but was modified a bit becausenode
is now expected at a specific path.load
command in theWORKSPACE
file, but declaring all the possible names seems simpler).yarn_install
now has ayarn
attribute that can point to a nix installed yarn, which we install with_nixpkgs_yarn
._declare_nix_node_toolchain_impl
rule) and register it.@rules_nodejs//nodejs:toolchain_type
.shellcheck
I encountered some shellcheck errors, mostly because it was trying to analyze template files which are not complete yet, so I added directives to these errors.
The
--experimental-wasm-bigint
optionThis option is not needed anymore with node 16, so the asterius bundle was updated to a new version to fix this (as mentioned in #1742).