Support for --incompatible_disable_starlark_host_transitions #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to support incompatible_disable_starlark_host_transitions
Merged
|
🎉 All dependencies have been resolved ! |
mergify
bot
deleted the
ylecornec/incompatible_disable_starlark_host_transitions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1908
This PR addressed #1846 by replacing the deprecated
cfg = "host"syntax bycfg = "exec", and updating some dependencies to a compatible version.This was tested with bazel 6 (see this branch) in This CI run by enabling the
--incompatible_disable_starlark_host_transitionsflag (this flag is not available on bazel 5).Note: Updating
rules_gois also needed to support--incompatible_disable_starlark_host_transitionsbut this requires updating the version of bazel used by the CI. So it will be part of the update to bazel 6.