Bazel ci fixes #1916
Merged
Bazel ci fixes #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All dependencies have been resolved ! |
ylecornec
force-pushed
the
ylecornec/bazel_ci
branch
from
ca2c374
to
0d706b2
Compare
avdv
reviewed
Jun 29, 2023
| @@ -58,8 +60,6 @@ build:ci-common --repository_cache=~/repo-cache/ | |||
| build:ci-common --experimental_repository_cache_hardlinks | |||
|
|
|||
| # Use a remote cache during CI | |||
| build:ci-common --bes_results_url=https://app.buildbuddy.io/invocation/ | |||
| build:ci-common --bes_backend=grpcs://remote.buildbuddy.io | |||
There was a problem hiding this comment.
Maybe it would make sense to still leverage the cache in general, but disable remote uploads with --noremote_upload_local_results, and re-enable remote uploads for the "ci" config with --remote_upload_local_results. Not sure this is possible.
avdv
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1912
This PR contains two changes to bazel's CI:
It updates
.bazelrc.commonto only use BuildBuddy for the build event service in our CI, but not in bazel's one.This fixes this error from the
Try update last green commitjob, which also contains the following warning at the top:It adds the tests from the
rules_haskell_testsmodule to bazel's CI.I needed to specify the platform explicitly when using a matrix because of this error which looks a bit like an issue in bazel's ci. It looks like the default platform gets expanded to
ubuntu1804_config_01here, which does not exist in thePLATFORMdictionary.The CI was run manually against this commit here.
Note: updating the latest green commit should make bazel's CI run against master in order to be sure that #1846 is fixed.