Include package dbs of source loaded dependencies in unit files #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package dbs are one of the few things that need to be transitively included in a unit file. Fix the following case: There are two units A and B, and A depends on B. B depends on an external dependency C. In this case the unit file for A needs to include the package db for C. HLS and GHC will not pick up the package db indirectly through B's unit file. Fix this by passing a set of package-db-only HaskellReplDepInfo when merging.
iteratee
force-pushed
the
kb/multi-hie-bios
branch
from
6416e44
to
6b3fdd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package dbs are one of the few things that need to be transitively included in a unit file. Fix the following case: There are two units A and B, and A depends on B. B depends on an external dependency C. In this case the unit file for A needs to include the package db for C. HLS and GHC will not pick up the package db indirectly through B's unit file. Fix this by passing a set of package-db-only HaskellReplDepInfo when merging.