Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency rules_go to v0.51.0 #631

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 16, 2024

This PR contains the following updates:

Package Type Update Change
rules_go bazel_dep minor 0.50.1 -> 0.51.0

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the merge-queue merge on green CI label Dec 16, 2024
@renovate renovate bot requested a review from a team as a code owner December 16, 2024 04:03
@jtacoma
Copy link

jtacoma commented Dec 31, 2024

This won't work because rules_go v0.51.0 is not backwards compatible with v0.50.1. See discussion on the pull request, including a comment that this might be fixed upstream in rules_go so that rules_nixpkgs can continue to work with both older and newer versions of rules_go (but not v0.51.0). If it is fixed upstream that way, then waiting for the next release of rules_go to restore the original API might be the best way to deal with this.

@malt3
Copy link
Collaborator

malt3 commented Dec 31, 2024

Thank you for pointing this out.
@jtacoma since you appear to be a user of rules_nixpkgs and the Go toolchain provided by it, do you have an opinion on #473? I'm trying to understand what value existing users get from a Go toolchain provided by Nix.

@jtacoma
Copy link

jtacoma commented Jan 1, 2025

Thank you for pointing this out. @jtacoma since you appear to be a user of rules_nixpkgs and the Go toolchain provided by it, do you have an opinion on #473? I'm trying to understand what value existing users get from a Go toolchain provided by Nix.

I didn't notice a problem when using rules_go without Nix yet in my hobby project but I expect I would soon. I like to freely mix programming languages and I've learned this works best when all parts of the final binary+libraries are built as similarly as possible. Since rules_nixpkgs_rust is required to use Bazel with Rust on Nix, I tried to use rules_nixpkgs for C++, Python, and Go too. With a local copy of rules_nixpkgs, some Bazel module overrides, and a tiny diff to work around this issue, I've now got a hello-world in each language. Hoping to find out soon whether I can link libraries from each language into a single binary!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue merge on green CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants