Support arbitrary indentation (#105) #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
aspiwack
reviewed
Mar 21, 2023
ErinvanderVeen
force-pushed
the
erin/105-hard-tab-support
branch
from
7d7b168 to
2698bdb
Compare
ErinvanderVeen
force-pushed
the
erin/105-hard-tab-support
branch
from
2698bdb to
5322ce4
Compare
|
Thank you very much. I'll shime in again when I start working on the Imba formatter :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #105
I was/am not sure about the regular expressions parsing of the arguments. They used to support multiple arguments, but I've reduced that to 1 because I could not reconcile that easily with " " string arguments.
Escaping is done by an old crate, but more modern alternatives are all GPL licensed. This isn't an issue to us, but could be a problem to future users of our library.