Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: override wasm-bindgen-cli with the version from the Cargo.lock #694

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

ErinvanderVeen
Copy link
Collaborator

@ErinvanderVeen ErinvanderVeen commented Apr 4, 2024

Thanks Nickel team for the inpiration: https://github.com/tweag/nickel/blob/6e79f0db56d7a66b70a3f7c6521ab4c4a286e89d/flake.nix#L84

This should avoid problems in the future when we update wasm-bindgen.

Resolves #686

Copy link
Member

@Xophmeister Xophmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really a Nix person, so I can only superficially approve. However, if it's the same code from Nickel, then that sets a good precedent 👍

flake.nix Show resolved Hide resolved
@ErinvanderVeen ErinvanderVeen merged commit bbad19d into main Apr 4, 2024
4 checks passed
@ErinvanderVeen ErinvanderVeen deleted the feat/pin-wasm-bindgen branch April 4, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin the Nix wasm-bindgen-cli dependencies, so they don't drift from those in Cargo.toml
2 participants