-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger CI on PR, as well as push #797
Conversation
There are still a few broken things... I will fix and resubmit for review. |
The problems appear to be with the WASM target, from the changes introduced in #794, if I'm following the log output correctly. It complains about a bunch of stuff in
|
I'm not sure how to solve this one. If I add this to the WASM module in impl From<tree_sitter::Point> for Point {
fn from(point: tree_sitter::Point) -> Self {
topiary_web_tree_sitter_sys::Point::new(point.row, point.column).into()
}
} The error changes to:
This is true and by design... |
...fixed that by avoiding the conversion call when targetting WASM. |
pull_request: | ||
branches: main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's any reason not to run CI on pull requests which don't target master. Especially since there's this playground branch that I believe we still have, which is also in production.
Also updated benchmark to use new
tree-sitter-ocaml
API.