Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .envrc #804

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Remove .envrc #804

merged 1 commit into from
Dec 10, 2024

Conversation

toastal
Copy link
Contributor

@toastal toastal commented Dec 10, 2024

Direnv is intended to be per-user config, not committed to the repository (same as you shouldn’t your text editor configuration). This is both poses a security risk to just run code, but also is preventing customization (& can introduced accidental commits as seen/forecasted in the Nixpkgs footnote link). This project unlike most identified that you may want multiple devShells but how does one put use use flake .#light if you remove that choice? Users that want an automatic shell can run echo "use flake .#default" > .envrc && direnv allow if they so choose.

See more discussion: NixOS/nixpkgs#325793

1

Footnotes

  1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute.

Prevents personalization & is a security risk
Copy link
Member

@Niols Niols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entirely agree.

@nbacquey nbacquey merged commit e9b8846 into tweag:main Dec 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants