Investigate and fix parallel grammar builds on Windows #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forcing |
2 tasks
Xophmeister
commented
Feb 5, 2025
nbacquey
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigate and fix parallel grammar builds on Windows
References #868
Description
For reasons, the MSVC linker does not like building multiple grammars concurrently and it hits a race condition 🤷 It's not at all clear why this happens, so the best we can do for the time being is stick a plaster over the problem: No concurrent grammar builds on Windows.
Checklist
Checklist before merging, wherever relevant:
CHANGELOG.mdupdatedREADME.mdup-to-date