chore: Use official grammar repo for OpenSCAD #896
Conversation
mkatychev
changed the title
|
@Xophmeister should I avoid manually updating |
mkatychev
changed the title
|
Seems there's compatibility issues: https://github.com/tweag/topiary/actions/runs/13704201091/job/38325408688?pr=896#step:9:618 |
| @@ -52,6 +52,7 @@ This name should be decided amongst the team before the release. | |||
| <!-- - <Changes in existing functionality> --> | |||
| - [#859](https://github.com/tweag/topiary/pull/859) Break up integration tests per language, thanks to @mkatychev | |||
| - [#871](https://github.com/tweag/topiary/pull/859) Switch to `mold` linker for CI tests, thanks to @mkatychev | |||
| - [#871](https://github.com/tweag/topiary/pull/896) Use official grammar repo for OpenSCAD, thanks to @mkatychev | |||
There was a problem hiding this comment.
| - [#871](https://github.com/tweag/topiary/pull/896) Use official grammar repo for OpenSCAD, thanks to @mkatychev | |
| - [#896](https://github.com/tweag/topiary/pull/896) Use official grammar repo for OpenSCAD, thanks to @mkatychev |
It's fine to update it outside of the automation we now have 👍 In fact, it's probably necessary for the CI to run on this PR.
Have the grammars changed between your version and this official version? I haven't looked into them, but that's the only thing I can think of (not that much has happened since your original OpenSCAD contribution was merged). |
Use official grammar repo for OpenSCAD
References Leathong/openscad-LSP#35
Description
tree-sitter-openscad has moved to the https://github.com/openscad org where the NPM package, crate, and python lib are pushed from. This PR updates the grammar location in
languages.nclandflake.nixto point to https://github.com/openscad/tree-sitter-openscad/Checklist
Checklist before merging, wherever relevant:
CHANGELOG.mdupdatedREADME.mdup-to-date