Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload full folder #42

Merged
merged 7 commits into from
Apr 8, 2024
Merged

Upload full folder #42

merged 7 commits into from
Apr 8, 2024

Conversation

diondokter
Copy link
Collaborator

No description provided.

@diondokter diondokter force-pushed the ci-binary-size branch 3 times, most recently from dde512a to 394c164 Compare April 8, 2024 12:38
Copy link

github-actions bot commented Apr 8, 2024

Smart Diff: Success

Check succeeded with tolerance same (expected same or better)

===================================================================
--- ./binsizes/binsize_master.txt
+++ ./binsizes/binsize_new.txt

Copy link

github-actions bot commented Apr 8, 2024

Smart Diff: Failure

Expected tolerance same but got worse instead

===================================================================
--- ./binsizes/binsize_master.txt
+++ ./binsizes/binsize_new.txt
@@ -1,23 +1,39 @@
+warning: constant `MAP_FLASH_RANGE` is never used
+  --> src/main.rs:20:11
+   |
+20 |     const MAP_FLASH_RANGE: Range<u32> = 0xFC000..0x100000;
+   |           ^^^^^^^^^^^^^^^
+   |
+   = note: `#[warn(dead_code)]` on by default
+
+warning: function `run_map` is never used
+  --> src/main.rs:85:10
+   |
+85 | async fn run_map<E: defmt::Format>(
+   |          ^^^^^^^
+
+warning: 2 warnings emitted
+
 example  :
 section               size        addr
 .vector_table          256         0x0
-.text                17904       0x100
-.rodata                 72      0x46f0
+.text                11656       0x100
+.rodata                  4      0x2e88
 .data                   56  0x20000000
-.gnu.sgstubs             0      0x4780
+.gnu.sgstubs             0      0x2ee0
 .bss                 32784  0x20000038
 .uninit               1024  0x20008048
-.defmt                  33         0x0
-.debug_loc          109431         0x0
-.debug_abbrev         4115         0x0
-.debug_info         276379         0x0
-.debug_aranges       10336         0x0
-.debug_ranges        37264         0x0
-.debug_str          264706         0x0
+.defmt                  24         0x0
+.debug_loc           99922         0x0
+.debug_abbrev         3993         0x0
+.debug_info         242751         0x0
+.debug_aranges        9920         0x0
+.debug_ranges        32440         0x0
+.debug_str          243194         0x0
 .comment                72         0x0
 .ARM.attributes         58         0x0
-.debug_frame         17568         0x0
-.debug_line          56222         0x0
-Total               828280
+.debug_frame         16444         0x0
+.debug_line          50320         0x0
+Total               744918
 
 

@diondokter diondokter force-pushed the ci-binary-size branch 2 times, most recently from d77c2e8 to 40090c3 Compare April 8, 2024 13:08
Copy link

github-actions bot commented Apr 8, 2024

PR build size diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -8.0%      -9  [ = ]       0    .defmt
 -31.2%     -20  [ = ]       0    [Unmapped]
 -60.7%     -68 -94.4%     -68    .rodata
  -2.9%    -122  [ = ]       0    .debug_abbrev
  -4.0%    -416  [ = ]       0    .debug_aranges
  -6.4% -1.10Ki  [ = ]       0    .debug_frame
 -25.7% -2.06Ki  [ = ]       0    .symtab
 -12.9% -4.71Ki  [ = ]       0    .debug_ranges
 -10.5% -5.76Ki  [ = ]       0    .debug_line
 -30.5% -5.96Ki  [ = ]       0    .strtab
 -34.8% -6.10Ki -34.9% -6.10Ki    .text
  -8.7% -9.29Ki  [ = ]       0    .debug_loc
  -8.1% -21.0Ki  [ = ]       0    .debug_str
 -12.2% -32.8Ki  [ = ]       0    .debug_info
 -11.1% -89.4Ki -12.1% -6.17Ki    TOTAL

Copy link

github-actions bot commented Apr 8, 2024

PR build size diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

1 similar comment
Copy link

github-actions bot commented Apr 8, 2024

PR build size diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Copy link

github-actions bot commented Apr 8, 2024

PR build size diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

1 similar comment
Copy link

github-actions bot commented Apr 8, 2024

PR build size diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

@diondokter diondokter merged commit cd27d8d into master Apr 8, 2024
5 checks passed
@diondokter diondokter deleted the ci-binary-size branch April 8, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant