-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split tween.js into separate files and bundle it with rollup. #331
Conversation
Hello Marti!
|
I like the file separation though! I just think it may be better to introduce smaller changes. I'm reading up on Buble now, looks cool. |
The output of Buble looks.... really nice. The question is, is it mature enough (as Babel)? For example, try this in Buble repl: let s = foo`
hello ${name}!
it's good to see you`; |
After thinking about it for a moment, I'm in favor of merging this commit because
Would the commit message need to be modified so that it follow semantic-release format? f.e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like
For reference, here's the bundled dist/TWEEN.js file that Rollup creates: https://gist.github.com/martikaljuve/a0629891480245aa31fc57f6724bbf7d |
@martikaljuve It is clean output! |
I'm trying to switch a project of mine to Buble, but no luck: https://gitlab.com/Rich-Harris/buble/issues/206 |
I have used gulp before so I might try gulp.
…On Tue, Aug 1, 2017 at 9:50 PM, Joseph Orbegoso Pea < ***@***.***> wrote:
I'm trying to switch a project of mine
<https://github.com/trusktr/infamous> to Buble, but no luck:
https://gitlab.com/Rich-Harris/buble/issues/206
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#331 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACCav-AoymCbjUBYwxrBo9VU2bFUtzixks5sUAAAgaJpZM4MkbVU>
.
|
@martikaljuve I finished switching infamous to Rollup+Buble, the result is awesome (the lean and clean output code). Can you resolve conflicts so we can move forward with the idea here? |
I just merged in another PR for Rollup. |
Similar to #327, but using Rollup + Bublé instead of babel to get a minimal bundle.
src
dir.