Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose isPlaying #356

Merged
merged 2 commits into from
Jul 14, 2017
Merged

Expose isPlaying #356

merged 2 commits into from
Jul 14, 2017

Conversation

siwel
Copy link
Contributor

@siwel siwel commented Jul 14, 2017

It can be useful to know if the tween is started, while the user could keep track of this themselves we already track this so I have added a getter to expose this.

siwel added 2 commits July 14, 2017 12:48
It can be useful to know if the tween is started, while the user could keep track of this themselves we already track this so I have added a getter to expose this.
@mikebolt
Copy link
Contributor

I think there's an issue with _isPlaying. It will be true after a tween finishes. Once that issue is fixed I can merge this.

@mikebolt mikebolt merged commit 96a9e4b into tweenjs:master Jul 14, 2017
@mikebolt
Copy link
Contributor

I made a small change to fix that issue, but there is still another issue. isPlaying() will return true after .start() is called, but before the tween actually starts, if a later start time is specified. It is not straightforward to fix this because the stop() method relies on _isPlaying and the stop() method is supposed to work even before the tween actually starts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants