#1029 - migrate requirements to setup.py, reference in requirements.txt #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcipolli
force-pushed
the
issue-1029-broken-setup
branch
from
88caa1f
to
778bd7a
Compare
dotlambda
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Apr 26, 2018
|
Looks good to me. I don't work in Python much so I'm a bit out of date with how packaging works. The method described in that post seems correct. 👍 |
Harmon758
referenced
this pull request
Jan 22, 2019
This was referenced Jan 22, 2019
Harmon758
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_requirementsis no longer available frompip. Followed guidance from https://caremad.io/posts/2013/07/setup-vs-requirement/ to work around this / fix the design bug in putting dependencies inrequirements.txtinstead ofsetup.py