omit relations from csv exports

twentyhq · Feb 28, 2024 · d3a3864 · d3a3864
1 parent b8b5fb4
commit d3a3864
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/...src/modules/object-record/record-index/options/hooks/__tests__/useExportTableData.test.ts b/...src/modules/object-record/record-index/options/hooks/__tests__/useExportTableData.test.ts
@@ -47,13 +47,18 @@ describe('generateCsv', () => {
       { label: 'Foo', metadata: { fieldName: 'foo' } },
       { label: 'Empty', metadata: { fieldName: 'empty' } },
       { label: 'Nested', metadata: { fieldName: 'nested' } },
+      {
+        label: 'Relation',
+        metadata: { fieldName: 'relation', relationType: 'TO_ONE_OBJECT' },
+      },
     ] as ColumnDefinition<FieldMetadata>[];
     const rows = [
       {
-        foo: 'some field',
         bar: 'another field',
         empty: null,
+        foo: 'some field',
         nested: { __typename: 'type', foo: 'foo', nested: 'nested' },
+        relation: 'a relation',
       },
     ];
     const csv = generateCsv({ columns, rows });

diff --git a/...s/twenty-front/src/modules/object-record/record-index/options/hooks/useExportTableData.ts b/...s/twenty-front/src/modules/object-record/record-index/options/hooks/useExportTableData.ts
@@ -33,7 +33,11 @@ export const generateCsv: GenerateExport = ({
   columns,
   rows,
 }: GenerateExportOptions): string => {
-  const keys = columns.flatMap((col) => {
+  const columnsWithoutRelations = columns.filter(
+    (col) => !('relationType' in col.metadata && col.metadata.relationType),
+  );
+
+  const keys = columnsWithoutRelations.flatMap((col) => {
     const column = {
       field: col.metadata.fieldName,
       title: col.label,
@@ -118,7 +122,7 @@ export const useExportTableData = ({
   useEffect(() => {
     const MAXIMUM_REQUESTS = Math.min(maximumRequests, totalCount / pageSize);
 
-    const downloadCav = (rows: object[]) => {
+    const downloadCsv = (rows: object[]) => {
       csvDownloader(filename, { rows, columns });
       setIsDownloading(false);
       setProgress(undefined);
@@ -138,7 +142,7 @@ export const useExportTableData = ({
     }
 
     if (!hasNextPage || pageCount >= MAXIMUM_REQUESTS) {
-      downloadCav(records);
+      downloadCsv(records);
     } else {
       fetchNextPage();
     }