-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all necessary currencies #7038
Comments
Currently we are using around 20 currency and based on currency picker library and npm modules, we need to add around 10-15 more currency to support most used currency around the world which would bring the total count to be around 35 |
Even if we all those 10-15 currencies, there are still more missing currencies according to ISO 4217 (https://en.wikipedia.org/wiki/ISO_4217#Active_codes_(list_one)), author of linked issue wanted to add a currency which isn't one of the most popular, so either:
|
@Bonapara what do you think, should all currencies be hardcoded or Twenty should allow adding them? If former, then I can implement this |
From fast check, it seems like there are missing icons for some currencies in icons-react package like Malagasy ariary or Ghanaian cedi, what should be done then? https://en.wikipedia.org/wiki/Currency_symbol |
Sure, that won't be a problem |
Related to #7038 --------- Co-authored-by: Charles Bochet <charles@twenty.com>
Related to twentyhq#7038 --------- Co-authored-by: Charles Bochet <charles@twenty.com>
Based on #7033 and other issues/PRs adding more currencies, instead of adding them one by one, it's better to add them all at once. This way, there won't be complaints about missing someone's currency or missing ability to add them by themselves in UI.
Tasks
The text was updated successfully, but these errors were encountered: