Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all necessary currencies #7038

Closed
3 tasks
BOHEUS opened this issue Sep 15, 2024 · 6 comments
Closed
3 tasks

Add all necessary currencies #7038

BOHEUS opened this issue Sep 15, 2024 · 6 comments
Labels

Comments

@BOHEUS
Copy link
Contributor

BOHEUS commented Sep 15, 2024

Based on #7033 and other issues/PRs adding more currencies, instead of adding them one by one, it's better to add them all at once. This way, there won't be complaints about missing someone's currency or missing ability to add them by themselves in UI.

Tasks

@harshit078
Copy link
Contributor

Currently we are using around 20 currency and based on currency picker library and npm modules, we need to add around 10-15 more currency to support most used currency around the world which would bring the total count to be around 35

@BOHEUS
Copy link
Contributor Author

BOHEUS commented Sep 15, 2024

Even if we all those 10-15 currencies, there are still more missing currencies according to ISO 4217 (https://en.wikipedia.org/wiki/ISO_4217#Active_codes_(list_one)), author of linked issue wanted to add a currency which isn't one of the most popular, so either:

  • all available currencies in the world are added or
  • Twenty should allow adding own currencies outside of base list

@Bonapara Bonapara added scope: backend Issues that are affecting the backend side only size: short for experienced contributor prio: low labels Sep 16, 2024
@BOHEUS
Copy link
Contributor Author

BOHEUS commented Oct 2, 2024

@Bonapara what do you think, should all currencies be hardcoded or Twenty should allow adding them? If former, then I can implement this

@BOHEUS
Copy link
Contributor Author

BOHEUS commented Oct 2, 2024

From fast check, it seems like there are missing icons for some currencies in icons-react package like Malagasy ariary or Ghanaian cedi, what should be done then? https://en.wikipedia.org/wiki/Currency_symbol

@Bonapara
Copy link
Member

Bonapara commented Oct 3, 2024

I think we can automate this. We use Tabler-icons for icons. Do you think we can fetch the available ones from Tabler-icons and display Coins when the currency is not available?

CleanShot 2024-10-03 at 10 36 42

@BOHEUS
Copy link
Contributor Author

BOHEUS commented Oct 3, 2024

Sure, that won't be a problem

BOHEUS added a commit to BOHEUS/twenty that referenced this issue Oct 4, 2024
charlesBochet added a commit to BOHEUS/twenty that referenced this issue Oct 4, 2024
BOHEUS added a commit to BOHEUS/twenty that referenced this issue Oct 5, 2024
charlesBochet added a commit that referenced this issue Oct 5, 2024
Related to #7038

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
@Bonapara Bonapara closed this as completed Oct 7, 2024
harshit078 pushed a commit to harshit078/twenty that referenced this issue Oct 14, 2024
Related to twentyhq#7038

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants