Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation on Select field option keys #8204

Closed
lucasbordeau opened this issue Oct 30, 2024 · 2 comments · Fixed by #8316
Closed

Add validation on Select field option keys #8204

lucasbordeau opened this issue Oct 30, 2024 · 2 comments · Fixed by #8316
Assignees
@ketanMehtaa

Comments

@lucasbordeau
Copy link
Contributor

lucasbordeau commented Oct 30, 2024 •
edited
Loading

Scope & Context

We can input special characters in Select API values

  • We need to change the label "API keys" to "API values" as it is misleading
image
@ketanMehtaa
Copy link
Contributor

assign me @lucasbordeau :)

@ketanMehtaa
Copy link
Contributor

@lucasbordeau just wants to confirm:

  1. You want to stop inputting special characters in Select API values, and
  2. change "API keys" to "API values". :)

@ketanMehtaa ketanMehtaa mentioned this issue Nov 4, 2024
Merged
FelixMalfait added a commit that referenced this issue Nov 14, 2024
@ketanMehtaa @FelixMalfait
validation on Select field (#8316)
51c54d4 
fix #8204
I changed "API keys" to "API values".
Stopped inputting special characters in Select field option keys.

@lucasbordeau please check the changes and tell me if I need to do any
other changes. :)

---------

Co-authored-by: Félix Malfait <felix@twenty.com>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Nov 14, 2024
khuddite pushed a commit to khuddite/twenty that referenced this issue Nov 18, 2024
@ketanMehtaa @FelixMalfait @khuddite
validation on Select field (twentyhq#8316)
67e9c4b 
fix twentyhq#8204
I changed "API keys" to "API values".
Stopped inputting special characters in Select field option keys.

@lucasbordeau please check the changes and tell me if I need to do any
other changes. :)

---------

Co-authored-by: Félix Malfait <felix@twenty.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ketanMehtaa ketanMehtaa

Labels
None yet
Projects
Product development ✅
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

validation on Select field ketanMehtaa/twenty
2 participants
@lucasbordeau @ketanMehtaa