Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an optional "secret" field on webhook for authentication #9187

Open
FelixMalfait opened this issue Dec 23, 2024 · 2 comments · May be fixed by #9219
Open

Add an optional "secret" field on webhook for authentication #9187

FelixMalfait opened this issue Dec 23, 2024 · 2 comments · May be fixed by #9219
Assignees
@samyakpiya
Labels
for experienced contributor good first issue Good for newcomers scope: back+front Issues requiring full-stack knowledge

Comments

@FelixMalfait
Copy link
Member

After the "Filters" section on a webhook edition page, add an optional field "Secret".

Sub-text:
Optional: Define a secret string that we will include in every webhook. Use this to authenticate and verify the webhook upon receipt.

Implement it when we send webhooks, update the open api spec.
@FelixMalfait FelixMalfait added for experienced contributor good first issue Good for newcomers scope: back+front Issues requiring full-stack knowledge labels Dec 23, 2024
@samyakpiya
Copy link
Contributor

Hi @FelixMalfait,

I'd like to be assigned to this issue.

@FelixMalfait
Copy link
Member Author

Thanks @samyakpiya

samyakpiya added a commit to samyakpiya/twenty that referenced this issue Dec 23, 2024
@samyakpiya
feat(webhooks-fe): implement secret field persistence (twentyhq#9187)
6faf293 
- Add secret field to Webhook type definition
- Implement secret field state management and persistence
- Connect secret field UI with data layer
@samyakpiya samyakpiya linked a pull request Dec 23, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samyakpiya samyakpiya

Labels
for experienced contributor good first issue Good for newcomers scope: back+front Issues requiring full-stack knowledge
Projects
Product development ✅
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Add webhook secret field (#9187) samyakpiya/twenty
2 participants
@FelixMalfait @samyakpiya