keyboard navigation for field selection #6969
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request implements keyboard navigation for field type selection in the data model settings, addressing issue #6954. Key changes include:
- Added keyboard navigation using Tab, Shift+Tab, and Enter keys in SettingsDataModelFieldTypeSelect component
- Introduced new SettingsDataModelHotkeyScope enum for managing hotkey scopes
- Created SettingsDataModelFieldConfigurationForm component for improved field configuration UI
- Updated SettingsObjectNewFieldStep2 to support toggling between field type selection and configuration steps
- Implemented styling updates for focused and active states to improve visual feedback
These changes enhance user experience and accessibility in the custom field creation process, aligning with the desired behavior outlined in the issue.
4 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings
| <SettingsDataModelFieldSettingsFormCard | ||
| fieldMetadataItem={{ | ||
| icon: formConfig.watch('icon'), | ||
| label: formConfig.watch('label') || 'Employees', |
There was a problem hiding this comment.
style: Consider using a more generic default label instead of 'Employees'
...src/modules/settings/data-model/fields/forms/components/SettingsDataModelFieldTypeSelect.tsx
Show resolved
Hide resolved
...src/modules/settings/data-model/fields/forms/components/SettingsDataModelFieldTypeSelect.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/data-model/types/SettingsDataModelHotKeyScope.ts
Outdated
Show resolved
Hide resolved
|
As discussed in the video call, let's deactivate the navigation in the breadcrumb step selector when no field type has been selected. Additionally, disable the Cancel and Save buttons on step one! |
|
@Bonapara 2024-09-11.13-58-00.mp4 |
|
@lucasbordeau could you please review this one? Thanks |
|
Could you please add a story so the coverage gets above 50 % ? |
|
@lucasbordeau These already have their corresponding stories! |
Adressing #6954
@Bonapara
How about this behaviour? The field wont be selected initially and then it is persistent once selected?
2024-09-10.18-16-32.mp4
Key navigation -
I couldnt show key strokes on screen like u do :)
2024-09-10.18-09-55.mp4