fix: fixed shortcuts population

[sid0-0]

This PR fixes #6776

Screenshots:

[github-actions]

Welcome!

Hello there, congrats on your first PR! We're excited to have you contributing to this project.
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.

Generated by 🚫 dangerJS against 5327b3d

[greptile-apps]

PR Summary

This pull request addresses issue #6776 by modifying the command menu functionality to filter out deactivated objects, preventing users from accessing them through shortcuts or the command menu.

• Added 'nameSingular' property to Command type and CommandMenuCommands for object identification
• Updated PageChangeEffect to use objectMetadataItemsState for filtering active items
• Modified useCommandMenu hook to include filterCommandMenu function and update setToInitialCommandMenu
• Adjusted CommandMenu.stories to incorporate changes for handling active/inactive object metadata items
• Implemented filtering logic to exclude deactivated objects from the command menu and shortcuts

_{5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

style: filterCommandMenu is unused in this component

[FelixMalfait]

Thanks a lot!
Sorry this could have been discussed upfront but tbh I think we should have done a loop and display all non isSystem +active objects like in settings, instead of filtering out from an hardcoded list. That way we could also get the icon directly from the true source in object metadata.
One thing we would lose is the shortcuts but we can bring them back later.

We have plans to isolate it into a dedicated entry point, not mixed with records:

("Objects" would open the list of objects you can navigate to)
Maybe this would be a good first step towards that.

What do you think?

[sid0-0]

@FelixMalfait
What exactly do you mean by isolate it into a dedicated entry point, not mixed with records (actually I don't know what records are)?

I have made changes to pick all data directly from object data.

Shortcuts are still functional as all initials are different and we won't run into any issues right now, in future we'll have to add a key for shortcut into object data itself (in case conflicts arise).

Note for reviewers: CommandMenu items' id has change from 'go-to-[labelPlural]' to uuid provided by the object. I can revert to using a generic go-to... string if required, but I didn't see any issues this would raise.

[lucasbordeau]

Please see in GotoHotkeysEffect in order to create something dynamic. Right now it's hard coded.