Add indexes to custom relations #7156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request adds functionality to create indexes for custom relations in the Twenty application.
- Introduced new
IndexMetadataServiceinindex-metadata.service.tsfor managing index creation and metadata - Modified
RelationMetadataServiceto create indexes on foreign key and deleted fields when new relations are created - Updated
IndexMetadataModuleto provide and exportIndexMetadataService - Integrated
IndexMetadataModuleintoRelationMetadataModulefor handling index operations on custom relations
4 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings
Comment on lines
34
to
36
| const columnNames: string[] = Array.from(fieldMetadataToIndexSet).map( | ||
| (fieldMetadata) => fieldMetadata.name as string, | ||
| ); |
There was a problem hiding this comment.
style: Unnecessary use of Array.from() on fieldMetadataToIndexSet which is already an array
Comment on lines
+63
to
+67
| if (!savedIndexMetadata) { | ||
| throw new Error( | ||
| `Failed to return saved index ${indexName} on object metadata ${objectMetadata.nameSingular}`, | ||
| ); | ||
| } |
There was a problem hiding this comment.
style: This check might be redundant as the save operation would throw an error if it failed
Comment on lines
+133
to
+138
| if (!foreignKeyFieldMetadata) { | ||
| throw new RelationMetadataException( | ||
| `ForeignKey field metadata not found`, | ||
| RelationMetadataExceptionCode.RELATION_METADATA_NOT_FOUND, | ||
| ); | ||
| } |
There was a problem hiding this comment.
logic: Check if foreignKeyFieldMetadata exists before proceeding
Comment on lines
+145
to
+150
| if (!deletedFieldMetadata) { | ||
| throw new RelationMetadataException( | ||
| `Deleted field metadata not found`, | ||
| RelationMetadataExceptionCode.RELATION_METADATA_NOT_FOUND, | ||
| ); | ||
| } |
There was a problem hiding this comment.
logic: Check if deletedFieldMetadata exists before proceeding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: command to retro-actively create indexes to existing custom objects