Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cropped company logos on the Companies Kanban #7166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harshit078
Copy link
Contributor

Note

This PR addresses the issue #7161
Removed margin right which made images crop.

Before

Screenshot 2024-09-20 at 1 35 55 AM

After

Screenshot 2024-09-20 at 1 35 34 AM

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses the issue of cropped company logos on the Companies Kanban board by modifying the RecordBoardCard component.

  • Removed right margin from company logos in packages/twenty-front/src/modules/object-record/record-board/record-board-card/components/RecordBoardCard.tsx
  • Allows full display of company logos without cutoff in the Kanban board view
  • Resolves issue Cropped company logos on the Companies Kanban #7161 reported in the project tracker
  • Visual improvement demonstrated with before and after screenshots in the PR description

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

Comment on lines 84 to 88
img {
height: ${({ theme }) => theme.icon.size.md}px;
margin-right: ${({ theme }) => theme.spacing(2)};
object-fit: cover;
width: ${({ theme }) => theme.icon.size.md}px;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider adding a small padding or margin to prevent logo from touching adjacent elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant