Basic test verifying if demo account is working properly #8442
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added new E2E test configuration and implementation to verify the demo account functionality and server availability status.
- Added new test project 'Demo check' in
/packages/twenty-e2e-testing/playwright.config.tsfor demo-specific testing - Created
/packages/twenty-e2e-testing/tests/demo_basic.spec.tsto verify demo server status with '@demo-only' tag - Test expects 'Server's on a coffee break' message with 10s timeout
- Hardcoded demo URL 'https://demo.twenty.com/' should be moved to environment configuration
- Special character encoding issue in error message text needs fixing ('â' in "Serverâs")
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
|
It needs small fix as right now when running this test from CLI, it launches additional test used by other tests when it shouldn't as there's no need to save the state of page after authorization. |
There was a problem hiding this comment.
PR Summary
(updates since last review)
Reorganized test files structure and improved test configurations for better maintainability and organization.
- Moved test files into
/tests/alldirectory with proper test matching patterns in playwright config - Added explicit testMatch patterns for chromium/firefox in
playwright.config.tstargeting/all/.+\.spec\.ts/ - Hardcoded test data in
/tests/all/companies.spec.tsneeds refactoring (13 rows count) - Empty test description in companies spec needs proper naming and documentation
4 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
| await page.getByRole('button', { name: 'Continue', exact: true }).click(); | ||
| await page.getByRole('button', { name: 'Sign in' }).click(); | ||
| await expect(page.getByText('Welcome to Twenty')).not.toBeVisible(); | ||
| await expect(page.getByText('Server’s on a coffee break')).toBeVisible({ |
There was a problem hiding this comment.
syntax: Special quote character 's is used instead of standard apostrophe. This may cause issues with string matching.
| await page.getByRole('button', { name: 'Continue With Email' }).click(); | ||
| await page.getByRole('button', { name: 'Continue', exact: true }).click(); | ||
| await page.getByRole('button', { name: 'Sign in' }).click(); |
There was a problem hiding this comment.
logic: No input validation or error handling for failed button clicks
|
Hey @BOHEUS thanks for this! I'm not sure we want to check external urls in a test like that. I think tests like that are meant to be able to run in an isolated environment. Otherwise this could break for things not related to the code. Tests are meant to help prevent error during deployment/PR but this is more of a reactive alert type of thing which should be done some place else. If we want to test demo/prod urls there are other QA tools we could probably use. |
|
I discussed with @charlesBochet and he doesn't agree with my comment. Could you try creating the github action so what what it'd look like? Maybe a cron running once a day that would send an email for example? Maybe we should add a Discord alert step https://github.com/marketplace/actions/action-notify |
|
No problem, I'll take care of it in free time, I'll focus on creating basic Github workflow with cron to run it once/twice per day and later I'll add additional features like email or Discord alert depending on needs |
No description provided.