Feature : Adding percentage option to Input Number #8481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 13, 2024 15:20
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds percentage type support to number fields, allowing users to configure decimal precision and display values with percentage formatting.
- Added percentage type option in
SettingsDataModelFieldNumberForm.tsxwith a new Select component for choosing between 'Number' and 'Percentage' types - Modified
NumberFieldDisplay.tsxandNumberFieldInput.tsxto handle percentage values by multiplying/dividing by 100 and appending '%' - Updated
useNumberField.tshook to handle percentage persistence with proper value conversion - Restructured field settings to be accessed through
metadata.settingsinstead of directsettingsproperty for better consistency - Added Zod validation schema in
field-metadata-validation.service.tsto validate percentage type and decimal settings
16 file(s) reviewed, 14 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/object-record/record-field/meta-types/hooks/useNumberField.ts
Outdated
Show resolved
Hide resolved
...ules/settings/data-model/fields/forms/number/components/SettingsDataModelFieldNumberForm.tsx
Outdated
Show resolved
Hide resolved
| @@ -13,6 +13,7 @@ type FieldMetadataDefaultSettings = { | |||
| type FieldMetadataNumberSettings = { | |||
| dataType: NumberDataType; | |||
| decimals?: number; | |||
| type?: string; | |||
There was a problem hiding this comment.
style: Consider using a union type 'percentage' | 'number' instead of string for better type safety
added 2 commits
November 13, 2024 16:39
Weiko
reviewed
Nov 13, 2024
packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts
Show resolved
Hide resolved
...wenty-server/src/engine/metadata-modules/field-metadata/field-metadata-validation.service.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/record-field/meta-types/hooks/useNumberField.ts
Outdated
Show resolved
Hide resolved
...ront/src/modules/object-record/record-field/meta-types/input/components/NumberFieldInput.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/record-field/types/FieldMetadata.ts
Outdated
Show resolved
Hide resolved
...rc/modules/settings/data-model/object-details/components/SettingsObjectFieldItemTableRow.tsx
Outdated
Show resolved
Hide resolved
|
feedback from Charles : disable percentage option on standard object ! |
|
Thanks @guillim for your contribution! |
khuddite
pushed a commit
to khuddite/twenty
that referenced
this pull request
Nov 18, 2024
fixing twentyhq#7375 --------- Co-authored-by: guillim <guillaume@twenty.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing #7375