fix - add new button on opportunity board company picker doesnt work #8488
+49
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes the "New" button functionality in the opportunity board's company picker by implementing company creation and improving data fetching.
- Added company creation flow in
RecordBoardColumnNewOpportunity.tsxusingcreateCompanyOpportunityAndOpenRightDrawerfunction - Implemented right drawer opening after company creation with proper state management via
viewableRecordIdState - Added
cache-and-networkfetch policy inuseFilteredSearchEntityQuery.tsto ensure immediate visibility of newly created companies - Added error handling with
isDefinedchecks for company creation responses
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+58
to
+61
| const createdCompany = await createCompany({ | ||
| id: newRecordId, | ||
| name: searchInput, | ||
| }); |
There was a problem hiding this comment.
logic: No error handling if company creation fails. Could leave UI in inconsistent state.
Comment on lines
+63
to
+65
| setViewableRecordId(newRecordId); | ||
| setViewableRecordNameSingular(CoreObjectNameSingular.Company); | ||
| openRightDrawer(RightDrawerPages.ViewRecord); |
There was a problem hiding this comment.
style: State updates and drawer opening should happen after confirming company creation succeeded
ehconitin
commented
Nov 13, 2024
| @@ -60,6 +60,7 @@ export const useFilteredSearchEntityQuery = ({ | |||
| filter: notFilter, | |||
| limit: limit ?? DEFAULT_SEARCH_REQUEST_LIMIT, | |||
| searchInput: searchFilter, | |||
| fetchPolicy: 'cache-and-network', | |||
There was a problem hiding this comment.
I am not sure about this one!
But the newly created entities won't get fetched without this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opportunitybutton.mp4