fix: search error in filter & sort dropdowns #8493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes a DOM manipulation error in the dropdown search functionality by consolidating menu items into a single container structure.
- Modified
ObjectFilterDropdownFilterSelect.tsxto prevent 'removeChild' error by unifying dropdown menu items under one container - Updated
ObjectSortDropdownButton.tsxto consolidate visible/hidden columns rendering within a singleDropdownMenuItemsContainer - Simplified dropdown structure while maintaining filter/sort functionality and visible/hidden column separation
- Added
DropdownMenuSeparatorinside the unified container instead of between separate containers
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Thanks @harshrajeevsingh for your contribution! |
charlesBochet
pushed a commit
that referenced
this pull request
Nov 15, 2024
Fixes: #8483 Co-authored-by: Félix Malfait <felix@twenty.com>
khuddite
pushed a commit
to khuddite/twenty
that referenced
this pull request
Nov 18, 2024
Fixes: twentyhq#8483 Co-authored-by: Félix Malfait <felix@twenty.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8483