Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(database): Add trigger to set impersonation on first user #9195

Merged
merged 2 commits into from
Dec 24, 2024
Merged

feat(database): Add trigger to set impersonation on first user #9195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aee3582
feat(database): Add trigger to set impersonation on first user
AMoreaux Dec 23, 2024
1b9aa15
refactor(auth): remove database trigger and update user creation
AMoreaux Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,9 +324,20 @@ export class SignInUpService {
lastName: string;
picture: SignInUpServiceInput['picture'];
}) {
const user: Partial<User> = {
email,
firstName,
lastName,
canImpersonate: false,
passwordHash,
};

if (!this.environmentService.get('IS_MULTIWORKSPACE_ENABLED')) {
const workspacesCount = await this.workspaceRepository.count();

// if the workspace doesn't exist it means it's the first user of the workspace
user.canImpersonate = true;

// let the creation of the first workspace
if (workspacesCount > 0) {
throw new AuthException(
Expand All @@ -351,23 +362,18 @@ export class SignInUpService {

const workspace = await this.workspaceRepository.save(workspaceToCreate);

const imagePath = await this.uploadPicture(picture, workspace.id);
user.defaultAvatarUrl = await this.uploadPicture(picture, workspace.id);

const userToCreate = this.userRepository.create({
email: email,
firstName: firstName,
lastName: lastName,
defaultAvatarUrl: imagePath,
canImpersonate: false,
passwordHash,
const userCreated = this.userRepository.create({
...user,
defaultWorkspace: workspace,
});

const user = await this.userRepository.save(userToCreate);
const newUser = await this.userRepository.save(userCreated);

await this.userWorkspaceService.create(user.id, workspace.id);
await this.userWorkspaceService.create(newUser.id, workspace.id);

await this.activateOnboardingForUser(user, workspace, {
await this.activateOnboardingForUser(newUser, workspace, {
firstName,
lastName,
});
Expand All @@ -377,7 +383,7 @@ export class SignInUpService {
value: true,
});

return user;
return newUser;
}

async uploadPicture(
Expand Down
Loading