support include function

[olets]

The include() functions is equivalent to the include tag. It breaks twig.js with "Cannot call method 'replace' of undefined."

Example:
{{ include('template.html', {foo: 'bar'}, with_context = false) }}
{% include 'template.html' with {'foo': 'bar'} only %}

http://twig.sensiolabs.org/doc/functions/include.html

edit following #392 (comment): I don't recall why this was closed. reopening

[hawkeyetwolf]

@olets, it does? What am I missing? I get:

TwigException: include function does not exist and is not defined in the context

[JohnAlbin]

I've added this to the implementation notes on the wiki. https://github.com/twigjs/twig.js/wiki/Implementation-Notes

[Bilge]

Why was this closed? The include function is the recommended method of inclusion, according to the docs:

Note: It is recommended to use the include function instead as it provides the same features with a bit more flexibility

If this is still not supported, it should be reopened.

[MothannaDoubaa]

Hello , any update here ?

[willrowe]

If someone is able to provide a TwigFiddle example that works and an example using this template that does not work, then I can look into it more.

[bronzehedwick]

Hey @willrowe

Here's the TwigFiddle showing the include() working as expected.

Here's the TwigJS version erroring out.

From the console:

TwigException: include function does not exist and is not defined in the context

[Geolim4]

Simple question: how can I use the include() function when the main template as been rendered from a string:

https://github.com/Geolim4/In-Memoriam/blob/60412b8730f68ecf2005c3694e41fdbb73254927/src/ts/Extensions/renderer.ts#L92

Should include() get implemented as a callback function on my own when Twig render is called on a string instead of a filename ?

[willrowe]

@Geolim4 you can't use the include function because it is not currently supported. This issue is for adding support for it.

[Geolim4]

@Geolim4 you can't use the include function because it is not currently supported. This issue is for adding support for it.

Ohhh okay, so the readme is a bit lying then -_-

[willrowe]

the readme is a bit lying then

What do you mean?

[Geolim4]

The implementation note says that "include" is supported while its not actually :(

https://github.com/twigjs/twig.js/wiki/Implementation-Notes

[willrowe]

I've added this to the implementation notes on the wiki. https://github.com/twigjs/twig.js/wiki/Implementation-Notes

@JohnAlbin did you update the implementation notes when you were under the impression that support had been added?

[JohnAlbin]

@willrowe I think you are misreading the docs. The include tag is listed as supported. I added the note about the include function that says:

include: Throws error: "include function does not exist and is not defined in the context" #392

[willrowe]

@JohnAlbin great, thanks for the clarification.

@Geolim4 the implementation notes are correct. It says that the include tag is supported and the include function is not.

[willrowe]

@Geolim4 this issue is for adding support for the include function, not for general troubleshooting.

[Geolim4]

@Geolim4 this issue is for adding support for the include function, not for general troubleshooting.

Still, the include tag is either unclear or not enough documented, so I think its indirectly related ?

[willrowe]

@Geolim4 this issue is a feature request. Please search through the existing issues and documentation. If there is nothing in there related to what you want to do then open a new issue.

[Dru-S]

Hi @willrowe, are there any update on this include function implementation?

[willrowe]

@Dru-S I have not had a chance to work on this yet, but if you want to submit a PR I will review it.