Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix twig {% if(x) %} and {% elseif(x) %} blocks parsing error #570

Merged
merged 3 commits into from
Jun 26, 2018
Merged

Fix twig {% if(x) %} and {% elseif(x) %} blocks parsing error #570

merged 3 commits into from
Jun 26, 2018

Conversation

toptalo
Copy link
Contributor

@toptalo toptalo commented Jun 26, 2018

Addresses #437

Also fix test case for {% set %} and some misprints in comments

Copy link
Collaborator

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dave-irvine dave-irvine merged commit 4138385 into twigjs:master Jun 26, 2018
@dave-irvine dave-irvine mentioned this pull request Jun 26, 2018
@toptalo toptalo deleted the issue-437 branch July 9, 2018 14:56
willrowe pushed a commit to willrowe/twig.js that referenced this pull request May 11, 2019
…igjs#570)

* Fix twig `{% if(x) %}` and `{% elseif(x) %}` blocks parsing error

* Unified tests

* Fix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants