Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'deprecated' tag #675

Merged
merged 1 commit into from
Nov 1, 2019

Conversation

josephineb
Copy link
Contributor

Compiling the 'deprecated' tag will result in a warning message in the console.

Note: The 'deprecated' tag was added PHP Twig 2.6, see: https://twig.symfony.com/doc/2.x/tags/deprecated.html.

Compiling the 'deprecated' tag will result in a warning message in the console.
Copy link

@denniscoorn denniscoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@ericmorand
Copy link
Contributor

+1 for using sinon in the test suite.

Copy link
Contributor

@maxhelias maxhelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@RobLoach
Copy link
Collaborator

RobLoach commented Nov 1, 2019

This is great! Thanks so much 👍

@RobLoach RobLoach merged commit 8270a18 into twigjs:master Nov 1, 2019
@josephineb
Copy link
Contributor Author

This is great! Thanks so much

Thanks! Any idea when a new version will be released?

@RobLoach
Copy link
Collaborator

RobLoach commented Nov 4, 2019

Anything in particular you think is holding it back? The changelog looks pretty solid.

@josephineb
Copy link
Contributor Author

No, I don't think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants