Allow colon inside Twig.expression.type.key.brackets.

[antoineveldhoven]

Fixes #854

Not sure why the colon is needed in de regexp for Twig.expression.type.key.brackets, @willrowe can you elaborate?

If it is not needed, removing the colon in the regexp will fix this issue.

[willrowe]

It appears that came for #362, but the tests from that PR appear to be passing, so it may have not been necessary to alter the regex originally. Can you double-check that PR and ensure that slicing still works?

[antoineveldhoven]

It appears that came for #362, but the tests from that PR appear to be passing, so it may have not been necessary to alter the regex originally. Can you double-check that PR and ensure that slicing still works?

Thanks for elaborating @willrowe !

As far as I can tell, the regexp with the colon is defined in Twig.expressions.js (line 578) Twig.expression.type.slice, so it is part of type slice and type.key.brackets are not used in this expression.

LGTM!

[RobLoach]

The tests are passing. Think this is good to go, @willrowe ?

[willrowe]

It should be, I think @antoineveldhoven is right and the regex must have been updated by mistake in the previous PR>