Move operator definitions to objects #4543
Merged
+2,541
−1,064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
operator-classes
branch
5 times, most recently
from
4461487 to
bd7a8df
Compare
smnandre
reviewed
Jan 19, 2025
fabpot
force-pushed
the
operator-classes
branch
from
bd7a8df to
4e4d23b
Compare
stof
reviewed
Jan 20, 2025
fabpot
force-pushed
the
operator-classes
branch
from
4e4d23b to
1fdaa88
Compare
stof
reviewed
Jan 20, 2025
fabpot
force-pushed
the
operator-classes
branch
5 times, most recently
from
1749107 to
3d0e2f3
Compare
|
New iteration where I have moved most pseudo-operators (logic hardcoded in |
fabpot
force-pushed
the
operator-classes
branch
5 times, most recently
from
339a8c3 to
4bf41b7
Compare
fabpot
commented
Jan 26, 2025
fabpot
force-pushed
the
operator-classes
branch
2 times, most recently
from
35ef5c7 to
0704840
Compare
stof
reviewed
Jan 29, 2025
fabpot
force-pushed
the
operator-classes
branch
2 times, most recently
from
dc96f57 to
ec728b6
Compare
stof
reviewed
Jan 31, 2025
fabpot
force-pushed
the
operator-classes
branch
2 times, most recently
from
c9cc79d to
df5904e
Compare
stof
reviewed
Feb 5, 2025
fabpot
force-pushed
the
operator-classes
branch
5 times, most recently
from
e140931 to
9c25c96
Compare
stof
reviewed
Feb 9, 2025
fabpot
force-pushed
the
operator-classes
branch
5 times, most recently
from
72748e3 to
10f2090
Compare
|
I think I've taken all comments into account now. |
…ns instead of arrays
fabpot
force-pushed
the
operator-classes
branch
from
10f2090 to
79d828b
Compare
smnandre
added a commit
to symfony/ux
that referenced
this pull request
Feb 22, 2025
…Parser) (smnandre) This PR was merged into the 2.x branch. Discussion ---------- [TwigComponent] Fix Twig 3.21 deprecations (getExpressionParser) | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT Following twigphp/Twig#4543 Commits ------- dfeb323 [TwigComponent] Fix getExpressionParser deprecations (Twig 3.21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.