-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies, allow disabling HTTP2, don't depend on twilight-http #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7596ff
reviewed
Dec 24, 2021
7596ff
previously approved these changes
Dec 24, 2021
Erk-
requested changes
Dec 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small nits
Erk-
previously approved these changes
Dec 24, 2021
7596ff
previously approved these changes
Dec 24, 2021
AEnterprise
previously approved these changes
Dec 27, 2021
Gelbpunkt
dismissed stale reviews from AEnterprise, 7596ff, and Erk-
via
December 28, 2021 20:13
c6b86f2
Erk-
approved these changes
Dec 28, 2021
AEnterprise
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
DISABLE_HTTP2
enviroment variable due to hyper connection pooling issues (http2 GOAWAY causes client to drop requests hyperium/hyper#2500, Http2: Hyper client gets stuck if too many requests are spawned hyperium/hyper#2419)