Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to UpdateStatus and INVITE_CREATE #110

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

Erk-
Copy link
Member

@Erk- Erk- commented Feb 28, 2020

UpdateStatus was errorously sending a indentify instead of an status
update opcode.

INVITE_CREATE had some errors in the documentation, they have not yet
been fixed, but I have confirmation that this is correct.

Signed-off-by: Valdemar Erk valdemar@erk.io


OBS: This PR depends on #103.

Note: This will probably ICE Clippy because of rust-lang/rust-clippy#5238.

@Erk- Erk- requested a review from Arzte as a code owner February 28, 2020 15:35
@Erk- Erk- added m-breaking change Breaks the public API. t-fix Fixes a bug in the library c-model Affects the model crate d-api Change related to Discord's API. labels Feb 28, 2020
UpdateStatus was errorously sending a indentify instead of an status
update opcode.

INVITE_CREATE had some errors in the documentation, they have not yet
been fixed, but I have confirmation that this is correct.

Signed-off-by: Valdemar Erk <valdemar@erk.io>
Copy link
Contributor

@Arzte Arzte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, nice catch.

@Erk- Erk- merged commit 4fa4ee5 into twilight-rs:master Feb 28, 2020
@Erk- Erk- deleted the model-fixes-2020-02-28 branch May 27, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-model Affects the model crate d-api Change related to Discord's API. m-breaking change Breaks the public API. t-fix Fixes a bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants