Add HTTP response model alias for models
#1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `model` alias for the `Response::models` method in `Response<ListBody<T>>` and `Response<MemberListBody>` implementations. This clears up some confusion and allows users to have a form of consistency if they choose to have it. Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
7596ff
approved these changes
Aug 20, 2021
AEnterprise
approved these changes
Aug 21, 2021
7596ff
pushed a commit
to 7596ff/twilight
that referenced
this pull request
Aug 25, 2021
Add a `model` alias for the `Response::models` method in `Response<ListBody<T>>` and `Response<MemberListBody>` implementations. This clears up some confusion and allows users to have a form of consistency if they choose to have it. Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
zeylahellyer
added a commit
that referenced
this pull request
Aug 30, 2021
Additions Support message components, including action rows, buttons, and select menus ([#1020], [#1043], [#1044], [#1090], aggregate [#1121] - [@AEnterprise], [@AsianIntel], [@zeylahellyer], [@7596ff]). Add comparing `StatusCode` with `u16` ([#1131] - [@zeylahellyer]). Add API error code 30040, described as "Maximum number of prune requests has been reached. Try again later" ([#1125] - [@zeylahellyer]). Enhancements Document that `tracing` is now disabled by default ([#1129] - [@zeylahellyer]). Add `Response<ListBody<T>>::model` and `Response<MemberListBody>::model` aliases corresponding to their `models` equivalents ([#1123] - [@zeylahellyer]). Display body parsing errors as a legible string if they're UTF-8 valid ([#1118] - [@AEnterprise]). [@7596ff]: https://github.com/7596ff [@AEnterprise]: https://github.com/AEnterprise [@AsianIntel]: https://github.com/AsianIntel [@zeylahellyer]: https://github.com/zeylahellyer [#1131]: #1131 [#1129]: #1129 [#1125]: #1125 [#1123]: #1123 [#1121]: #1121 [#1120]: #1120 [#1118]: #1118 [#1090]: #1090 [#1044]: #1044 [#1043]: #1043 [#1020]: #1020 Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
7596ff
pushed a commit
to 7596ff/twilight
that referenced
this pull request
Aug 30, 2021
Additions Support message components, including action rows, buttons, and select menus ([twilight-rs#1020], [twilight-rs#1043], [twilight-rs#1044], [twilight-rs#1090], aggregate [twilight-rs#1121] - [@AEnterprise], [@AsianIntel], [@zeylahellyer], [@7596ff]). Add comparing `StatusCode` with `u16` ([twilight-rs#1131] - [@zeylahellyer]). Add API error code 30040, described as "Maximum number of prune requests has been reached. Try again later" ([twilight-rs#1125] - [@zeylahellyer]). Enhancements Document that `tracing` is now disabled by default ([twilight-rs#1129] - [@zeylahellyer]). Add `Response<ListBody<T>>::model` and `Response<MemberListBody>::model` aliases corresponding to their `models` equivalents ([twilight-rs#1123] - [@zeylahellyer]). Display body parsing errors as a legible string if they're UTF-8 valid ([twilight-rs#1118] - [@AEnterprise]). [@7596ff]: https://github.com/7596ff [@AEnterprise]: https://github.com/AEnterprise [@AsianIntel]: https://github.com/AsianIntel [@zeylahellyer]: https://github.com/zeylahellyer [twilight-rs#1131]: twilight-rs#1131 [twilight-rs#1129]: twilight-rs#1129 [twilight-rs#1125]: twilight-rs#1125 [twilight-rs#1123]: twilight-rs#1123 [twilight-rs#1121]: twilight-rs#1121 [twilight-rs#1120]: twilight-rs#1120 [twilight-rs#1118]: twilight-rs#1118 [twilight-rs#1090]: twilight-rs#1090 [twilight-rs#1044]: twilight-rs#1044 [twilight-rs#1043]: twilight-rs#1043 [twilight-rs#1020]: twilight-rs#1020 Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
7596ff
pushed a commit
to 7596ff/twilight
that referenced
this pull request
Aug 30, 2021
Additions Support message components, including action rows, buttons, and select menus ([twilight-rs#1020], [twilight-rs#1043], [twilight-rs#1044], [twilight-rs#1090], aggregate [twilight-rs#1121] - [@AEnterprise], [@AsianIntel], [@zeylahellyer], [@7596ff]). Add comparing `StatusCode` with `u16` ([twilight-rs#1131] - [@zeylahellyer]). Add API error code 30040, described as "Maximum number of prune requests has been reached. Try again later" ([twilight-rs#1125] - [@zeylahellyer]). Enhancements Document that `tracing` is now disabled by default ([twilight-rs#1129] - [@zeylahellyer]). Add `Response<ListBody<T>>::model` and `Response<MemberListBody>::model` aliases corresponding to their `models` equivalents ([twilight-rs#1123] - [@zeylahellyer]). Display body parsing errors as a legible string if they're UTF-8 valid ([twilight-rs#1118] - [@AEnterprise]). [@7596ff]: https://github.com/7596ff [@AEnterprise]: https://github.com/AEnterprise [@AsianIntel]: https://github.com/AsianIntel [@zeylahellyer]: https://github.com/zeylahellyer [twilight-rs#1131]: twilight-rs#1131 [twilight-rs#1129]: twilight-rs#1129 [twilight-rs#1125]: twilight-rs#1125 [twilight-rs#1123]: twilight-rs#1123 [twilight-rs#1121]: twilight-rs#1121 [twilight-rs#1120]: twilight-rs#1120 [twilight-rs#1118]: twilight-rs#1118 [twilight-rs#1090]: twilight-rs#1090 [twilight-rs#1044]: twilight-rs#1044 [twilight-rs#1043]: twilight-rs#1043 [twilight-rs#1020]: twilight-rs#1020 Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
MaxOhn
pushed a commit
to MaxOhn/twilight
that referenced
this pull request
Oct 7, 2021
Additions Support message components, including action rows, buttons, and select menus ([twilight-rs#1020], [twilight-rs#1043], [twilight-rs#1044], [twilight-rs#1090], aggregate [twilight-rs#1121] - [@AEnterprise], [@AsianIntel], [@zeylahellyer], [@7596ff]). Add comparing `StatusCode` with `u16` ([twilight-rs#1131] - [@zeylahellyer]). Add API error code 30040, described as "Maximum number of prune requests has been reached. Try again later" ([twilight-rs#1125] - [@zeylahellyer]). Enhancements Document that `tracing` is now disabled by default ([twilight-rs#1129] - [@zeylahellyer]). Add `Response<ListBody<T>>::model` and `Response<MemberListBody>::model` aliases corresponding to their `models` equivalents ([twilight-rs#1123] - [@zeylahellyer]). Display body parsing errors as a legible string if they're UTF-8 valid ([twilight-rs#1118] - [@AEnterprise]). [@7596ff]: https://github.com/7596ff [@AEnterprise]: https://github.com/AEnterprise [@AsianIntel]: https://github.com/AsianIntel [@zeylahellyer]: https://github.com/zeylahellyer [twilight-rs#1131]: twilight-rs#1131 [twilight-rs#1129]: twilight-rs#1129 [twilight-rs#1125]: twilight-rs#1125 [twilight-rs#1123]: twilight-rs#1123 [twilight-rs#1121]: twilight-rs#1121 [twilight-rs#1120]: twilight-rs#1120 [twilight-rs#1118]: twilight-rs#1118 [twilight-rs#1090]: twilight-rs#1090 [twilight-rs#1044]: twilight-rs#1044 [twilight-rs#1043]: twilight-rs#1043 [twilight-rs#1020]: twilight-rs#1020 Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
modelalias for theResponse::modelsmethod inResponse<ListBody<T>>andResponse<MemberListBody>implementations.This clears up some confusion and allows users to have a form of consistency if they choose to have it.