-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(http,model)!: auto moderation http methods and mention spam #1846
Conversation
Add requests `CreateAutoModerationRule`, `DeleteAutoModerationRule`, `GetAutoModerationRule`, `GetGuildAutoModerationRules`, and `UpdateAutoModerationRule`. `CreateAutoModerationRule` ensures the correct trigger metadata is supplied by replacing `exec` with `with_trigger_keyword`, `with_harmful_link, `with_spam`, and `with_trigger_keyword_preset`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to see tests of the routes display implementation too.
twilight-http/src/request/guild/auto_moderation/create_auto_moderation_rule.rs
Show resolved
Hide resolved
twilight-http/src/request/guild/auto_moderation/update_auto_moderation_rule.rs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation can be iterated on at another time (based on user feedback)
Still looks good |
Remove reasons from being internally stored on the `GetAutoModerationRule` request. Because this was never exposed and in practice never used we can remove it due to the endpoint not supporting it. Surfaced in the original PR adding the request, #1846.
Remove reasons from being internally stored on the `GetAutoModerationRule` request. Because this was never exposed and in practice never used we can remove it due to the endpoint not supporting it. Surfaced in the original PR adding the request, #1846.
Closes #1709.
Closes #1867.
Changelog
Remove
TriggerType::HarmfulLink
, addTriggerType::MentionSpam
.Add requests
CreateAutoModerationRule
,DeleteAutoModerationRule
,GetAutoModerationRule
,GetGuildAutoModerationRules
, andUpdateAutoModerationRule
.CreateAutoModerationRule
ensures the correct trigger metadata is supplied by replacingexec
withwith_trigger_keyword
,with_spam
, andwith_trigger_keyword_preset
.