Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http,model)!: auto moderation http methods and mention spam #1846

Merged
merged 15 commits into from
Oct 28, 2022

Conversation

7596ff
Copy link
Contributor

@7596ff 7596ff commented Jul 20, 2022

Closes #1709.

Closes #1867.

Changelog

Remove TriggerType::HarmfulLink, add TriggerType::MentionSpam.

Add requests CreateAutoModerationRule, DeleteAutoModerationRule, GetAutoModerationRule, GetGuildAutoModerationRules, and UpdateAutoModerationRule.

CreateAutoModerationRule ensures the correct trigger metadata is supplied by replacing exec with with_trigger_keyword, with_spam, and with_trigger_keyword_preset.

Add requests `CreateAutoModerationRule`, `DeleteAutoModerationRule`,
`GetAutoModerationRule`, `GetGuildAutoModerationRules`, and
`UpdateAutoModerationRule`.

`CreateAutoModerationRule` ensures the correct trigger metadata is
supplied by replacing `exec` with `with_trigger_keyword`,
`with_harmful_link, `with_spam`, and `with_trigger_keyword_preset`.
@github-actions github-actions bot added c-http Affects the http crate c-http-ratelimiting Affects the http ratelimiting crate t-feature Addition of a new feature labels Jul 20, 2022
@7596ff 7596ff mentioned this pull request Jul 20, 2022
11 tasks
@7596ff 7596ff linked an issue Jul 20, 2022 that may be closed by this pull request
11 tasks
Copy link
Member

@vilgotf vilgotf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see tests of the routes display implementation too.

@7596ff 7596ff requested a review from vilgotf July 22, 2022 00:31
Copy link
Member

@vilgotf vilgotf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation can be iterated on at another time (based on user feedback)

@itohatweb itohatweb self-requested a review September 16, 2022 22:06
@github-actions github-actions bot added c-model Affects the model crate c-validate Affects the validate crate labels Sep 21, 2022
@7596ff 7596ff changed the title feat(http): auto moderation http methods feat(http): auto moderation http methods and mention spam Sep 21, 2022
@7596ff 7596ff changed the title feat(http): auto moderation http methods and mention spam feat(http,model)!: auto moderation http methods and mention spam Sep 21, 2022
@github-actions github-actions bot added the m-breaking change Breaks the public API. label Sep 21, 2022
@vilgotf
Copy link
Member

vilgotf commented Sep 22, 2022

Still looks good

@7596ff 7596ff merged commit 57fc41c into main Oct 28, 2022
@7596ff 7596ff deleted the 7596ff/feat/auto-moderation-http branch October 28, 2022 19:25
zeylahellyer added a commit that referenced this pull request Mar 1, 2023
Remove reasons from being internally stored on the
`GetAutoModerationRule` request. Because this was never exposed and in
practice never used we can remove it due to the endpoint not supporting
it.

Surfaced in the original PR adding the request, #1846.
zeylahellyer added a commit that referenced this pull request Mar 9, 2023
Remove reasons from being internally stored on the
`GetAutoModerationRule` request. Because this was never exposed and in
practice never used we can remove it due to the endpoint not supporting
it.

Surfaced in the original PR adding the request, #1846.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-http Affects the http crate c-http-ratelimiting Affects the http ratelimiting crate c-model Affects the model crate c-validate Affects the validate crate m-breaking change Breaks the public API. t-feature Addition of a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto Moderation: Support MENTION_SPAM Support Auto Moderation
2 participants