perf(gateway): remove one Shard::next_message allocation
#1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-gateway
vilgotf
force-pushed
the
vilgotf/perf/gateway/next-message-alloc
branch
from
4231c31
to
aed068b
Compare
|
This contains elements of #1947, which I would like to resolve before commenting further. |
vilgotf
force-pushed
the
vilgotf/perf/gateway/next-message-alloc
branch
from
7366a6e
to
fdedcbc
Compare
vilgotf
changed the base branch from
next
to
vilgotf/feat/gateway/heartbeat-jitter
Base automatically changed from
vilgotf/feat/gateway/heartbeat-jitter
to
next
October 16, 2022 06:33
vilgotf
force-pushed
the
vilgotf/perf/gateway/next-message-alloc
branch
from
fdedcbc
to
23cb50c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twilight uses
Box::pinwhen pinning is required, but allocating aBoxis in most cases not needed.pin-project-liteavoids this allocation and internally guarentees that the safety contract ofPin::new_uncheckedis upheld.Although the entire
NextMessageFuturecan be replaced withtokio::select!(with biased), this is not done due to its archaic syntax.pin-project-liteis commonly used in the async ecosystem and Twilight already transiently depends upon it via, for example,tokioandhyper.Doc comments cannot be put on struct items due to taiki-e/pin-project-lite#3, the recommended workaround is to use normal comments instead.