perf(gateway): remove one Shard::next_message
allocation
#1900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twilight uses
Box::pin
when pinning is required, but allocating aBox
is in most cases not needed.pin-project-lite
avoids this allocation and internally guarentees that the safety contract ofPin::new_unchecked
is upheld.Although the entire
NextMessageFuture
can be replaced withtokio::select!
(with biased), this is not done due to its archaic syntax.pin-project-lite
is commonly used in the async ecosystem and Twilight already transiently depends upon it via, for example,tokio
andhyper
.Doc comments cannot be put on struct items due to taiki-e/pin-project-lite#3, the recommended workaround is to use normal comments instead.