feat(model): add invite type #2346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-model
laralove143
requested changes
May 16, 2024
| pub const fn name(&self) -> &str { | ||
| match self { | ||
| Self::Guild => "Guild", | ||
| Self::GroupDM => "Group DM", |
There was a problem hiding this comment.
in other similar types we follow the name of the variant itself so it'd be GroupDm
There was a problem hiding this comment.
whats the reason you used Group instead of GroupDm
laralove143
requested changes
May 16, 2024
laralove143
requested changes
May 16, 2024
| serde_test::assert_tokens(&InviteType::Friend, &[Token::U8(2)]); | ||
| serde_test::assert_tokens(&InviteType::Unknown(99), &[Token::U8(99)]); | ||
| } | ||
|
|
||
| #[test] | ||
| fn names() { | ||
| assert_eq!(InviteType::Guild.name(), "Guild"); | ||
| assert_eq!(InviteType::GroupDM.name(), "Group DM"); |
There was a problem hiding this comment.
this test doesnt seem to be updated according to the changes on name function
Erk-
requested changes
May 20, 2024
AEnterprise
reviewed
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: