chore(cypress): turn on new cypress tests in ci #2056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
andioneto
commented
Nov 17, 2021
| @@ -85,7 +85,7 @@ declare namespace Cypress { | |||
| Cypress.Commands.add('getDocsPageContentArea', () => cy.get('#paste-docs-content-area')); | |||
|
|
|||
| Cypress.Commands.add('pageHeaderShouldBeVisible', (headerText) => { | |||
| cy.contains('h1', headerText).shouldBeVisible(); | |||
| cy.contains('h1', headerText, {matchCase: false}).shouldBeVisible(); | |||
There was a problem hiding this comment.
Turning on loose text matching since we are already matching the header with the h1 element.
andioneto
commented
Nov 17, 2021
| @@ -70,7 +70,7 @@ | |||
| "test:tools": "jest ./tools/ -c ./tools/jest.config.js", | |||
| "test:tools-16": "USE_REACT_16=true jest ./tools/ -c ./tools/jest.config.js", | |||
| "test:coverage": "yarn pre-test && jest --coverage", | |||
| "test:website": "start-server-and-test 'yarn serve:website' http://localhost:9000 'yarn cypress run --record --spec ./cypress/integration/**/*.spec.ts'", | |||
| "test:website": "start-server-and-test 'yarn serve:website' http://localhost:9000 'yarn cypress run --record --spec ./cypress/integration/**/**/*.spec.ts'", | |||
There was a problem hiding this comment.
Include all specs in ci tests.
|
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: 33f0826 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/619729641f4c390007b1ea8b 😎 Browse the preview: https://deploy-preview-2056--paste-theme-designer.netlify.app |
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: 33f0826 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/61972964a2139d0007522d53 😎 Browse the preview: https://deploy-preview-2056--paste-docs.netlify.app |
|
Size Change: 0 B Total Size: 449 kB ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5b27fd4:
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ FailuresThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
shleewhite
approved these changes
Nov 18, 2021
|
The code looks ok, but I am worried that 2 of the tests timed out on cypress.. This happened before with the sidebar and we ended up having to change the test bc cypress wouldn't scroll to find the sidebar links. Is it always the same tests that time out (Tabs and Stack)? Or would it fluctuate from run to run? |
|
Also concerned about the two flakes Worth considering: how much additional protection are we getting by testing every single page for the same thing when they all follow the same structure, VS how much we're waiting or spending on running those tests. |
|
@TheSisb @shleewhite I'll look at these now. FWIW I ran these tests 10 times locally and they all passed (including the flakey tests check). With regard to the fix up for the sidebar, I have a separate branch with an upgrade to cypress v8 and that is not an ideal solution for the problem. I added a cypress command to find items in a fixed container, which also works for sidebar. Will post an update when I have one. |
andioneto
force-pushed
the
chore/cypress-coverage-spec
branch
from
7a3fb9d to
9da8464
Compare
github-actions
bot
added
the
Area: Infrastructure
andioneto
force-pushed
the
chore/cypress-coverage-spec
branch
from
8a04ed5 to
c78fe79
Compare
|
Closing in favor of: #2063 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio