-
Notifications
You must be signed in to change notification settings - Fork 119
Feat/form components changes #4311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
da0fd28
c388bc4
83e3877
31ddc63
59fab90
62bbfcb
8fd8090
498e674
7a579b0
e4ef93d
51fb20d
b41d4ec
cb546bc
ab517d0
5a68c69
0262ab6
4d4b445
b789f55
6cdd66c
68a08db
29cab8d
4b5cdfc
75d23bd
0ec57d8
1bf4f41
99e8bf9
8a7fb93
1d28c0c
61bd22c
f45dd3e
6c946ac
aa0d119
f2918c5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
--- | ||
"@twilio-paste/base-radio-checkbox": patch | ||
"@twilio-paste/button": patch | ||
"@twilio-paste/checkbox": patch | ||
"@twilio-paste/combobox": patch | ||
"@twilio-paste/file-picker": patch | ||
"@twilio-paste/file-uploader": patch | ||
"@twilio-paste/input": patch | ||
"@twilio-paste/input-box": patch | ||
"@twilio-paste/menu": patch | ||
"@twilio-paste/select": patch | ||
"@twilio-paste/textarea": patch | ||
"@twilio-paste/visual-picker": patch | ||
"@twilio-paste/core": patch | ||
--- | ||
|
||
[Base Radio Checkbox, Button, Combobox, File Picker, File Uploader, Input, Input Box, Menu, Select, Textarea, Visual Picker] Update styles of form related components |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@twilio-paste/design-tokens": patch | ||
"@twilio-paste/core": patch | ||
--- | ||
|
||
[Design Tokens] Update palette and new elevation token |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@twilio-paste/label": minor | ||
"@twilio-paste/core": minor | ||
--- | ||
|
||
[Label] Update font weight, expose new prop for optional variant and fix require dot causing scrolling issue |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,9 +30,9 @@ const defaultStyles: BoxStyleProps = merge(BaseStyles.default, { | |
}); | ||
|
||
const loadingStyles: BoxStyleProps = merge(BaseStyles.loading, { | ||
color: "colorTextDestructive", | ||
color: "colorTextWeaker", | ||
backgroundColor: "colorBackgroundBody", | ||
boxShadow: "shadowBorderWeak", | ||
boxShadow: "shadowBorderWeaker", | ||
Comment on lines
+33
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion: All the loading styles for buttons inherit from baseLoadingStyles right? If the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. only |
||
}); | ||
|
||
const disabledStyles: BoxStyleProps = merge(BaseStyles.disabled, { | ||
|
Unchanged files with check annotations Beta
convertRawTokenJSONToArray({ | ||
"color-text-weak": { | ||
type: "color", | ||
category: "text-color", | ||
value: "#aeb2c1", | ||
comment: "Weaker body text for visual hierarchy. Inaccessible unless used on disabled controls.", | ||
originalValue: "{!palette-gray-40}", |
const { defineTest } = require("jscodeshift/dist/testUtils"); | ||
Check warning on line 1 in packages/paste-codemods/transforms/__tests__/barreled-to-unbarreled.spec.tsx
|
||
defineTest(__dirname, "barreled-to-unbarreled", null, "barreled-to-unbarreled", { parser: "ts" }); | ||
let packageExports = {}; | ||
try { | ||
// eslint-disable-next-line global-require, import/no-dynamic-require | ||
packageExports = require(name); | ||
Check warning on line 26 in packages/paste-codemods/tools/generatePackageExportsMap.ts
|
||
} catch (error) { | ||
// eslint-disable-next-line no-console | ||
console.log(`Failed to dynamically require package: ${name}`, error); |
const mapping = await generatePackageExportsMap(); | ||
// Write to disk | ||
writeToFile(path.join(__dirname, ".cache/mappings.json"), mapping, { | ||
successMessage: "Wrote core packages export mapping to .cache/mappings.json file!", | ||
errorMessage: "Could not generate mappings!", | ||
formatJson: true, |
const mockMapping = await generatePackageExportsMap(mockGetPastePackages); | ||
expect(mockMapping).toEqual({ | ||
BOX_PROPS_TO_BLOCK: "@twilio-paste/core/box", | ||
Box: "@twilio-paste/core/box", | ||
ComboboxPrimitive: "@twilio-paste/core/combobox-primitive", | ||
DisclosurePrimitive: "@twilio-paste/core/disclosure-primitive", | ||
DisclosurePrimitiveContent: "@twilio-paste/core/disclosure-primitive", | ||
Stack: "@twilio-paste/core/stack", | ||
getCustomElementStyles: "@twilio-paste/core/box", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.