Skip to content

Print domain for activate command #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dkundel opened this issue Jul 17, 2019 · 0 comments
Closed

Print domain for activate command #37

dkundel opened this issue Jul 17, 2019 · 0 comments
Labels
v-next

Comments

@dkundel
Copy link
Contributor

dkundel commented Jul 17, 2019

Right now it only prints a success message but it should at least print the domain that has been activated
@dkundel dkundel added the v-next label Jul 19, 2019
dkundel added a commit that referenced this issue Jul 19, 2019
@dkundel
feat(activate): print deployment URL after activating
085eb36 
fix: #37
@dkundel dkundel closed this as completed Jul 19, 2019
dkundel added a commit to twilio-labs/serverless-api that referenced this issue Jul 23, 2019
@dkundel
feat(client): expose domain in activate command
8283662 
re: twilio-labs/serverless-toolkit#37
dkundel added a commit that referenced this issue Aug 10, 2020
@dkundel
feat(client): expose domain in activate command
ffa71fa 
re: #37
dkundel pushed a commit that referenced this issue Aug 10, 2020
@philnash
feat!: introduce rate limiting (#42)
e16e85a 
This centralises calls to `got` in the `TwilioServerlessApiClient`. Instead of making calls directly on the `got` client, we now make calls through the `TwilioServerlessApiClient`'s `request` method. This allows us to add concurrency limiting and retry logic to those calls in a central place.

* Uses `p-limit` to limit concurrency with a default level of 50 concurrent calls (Twilio limit is 100)
* Concurrency is configurable
* [Uses `got` to retry failed calls](https://www.npmjs.com/package/got#retry) with a limit of 10 retries (`got` only retries specific failures including 429 errors)

Fixes #37.
BREAKING CHANGE: the function signature of the individual functions changed. If you only use the methods on the client, nothing should have changed.
dkundel added a commit that referenced this issue Aug 10, 2020
@dkundel
feat(client): expose domain in activate command
d0294b5 
re: #37
dkundel pushed a commit that referenced this issue Aug 10, 2020
@philnash @dkundel
feat!: introduce rate limiting (#42)
902e749 
This centralises calls to `got` in the `TwilioServerlessApiClient`. Instead of making calls directly on the `got` client, we now make calls through the `TwilioServerlessApiClient`'s `request` method. This allows us to add concurrency limiting and retry logic to those calls in a central place.

* Uses `p-limit` to limit concurrency with a default level of 50 concurrent calls (Twilio limit is 100)
* Concurrency is configurable
* [Uses `got` to retry failed calls](https://www.npmjs.com/package/got#retry) with a limit of 10 retries (`got` only retries specific failures including 429 errors)

Fixes #37.
BREAKING CHANGE: the function signature of the individual functions changed. If you only use the methods on the client, nothing should have changed.
This was referenced Sep 13, 2021
Closed
Closed
This was referenced Sep 26, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v-next
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dkundel