Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated package.json to point to cli-core release candidate and cli-test new release #273

Merged
merged 3 commits into from
Jul 28, 2021
Merged

chore: Updated package.json to point to cli-core release candidate and cli-test new release #273

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29c3c26
[chore] - Updating package.json to point to cli-core release candidat…
ravali-rimmalapudi Jul 28, 2021
922138a
Removed the cli-test version upgrade.
ravali-rimmalapudi Jul 28, 2021
386a7d2
Added the shortform
ravali-rimmalapudi Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"@oclif/plugin-plugins": "^1.8.3",
"@oclif/plugin-warn-if-update-available": "^1.7.0",
"@sendgrid/mail": "^7.2.1",
"@twilio/cli-core": "^5.9.1",
"@twilio/cli-core": "https://github.com/twilio/twilio-cli-core.git#5.26.1-rc",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the docs, If the tag does not exist in the registry data for the package, it will fail. So added tag from github directly.
Please suggest if we have any other better way to do this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, since it's not published to npm yet, it should be fine to go via github tags route untill the changes are pushed to main.

[Q] This might not work with the Librarian logic for the PR you added for bumping up the version right? Or does it pick up the parsed tag version itself while bumping up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently librarian is picking the version from changes.md not from package.json. In librarian I have added the change to bump the version as -rc if the branch is not main but not yet pushed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - Might consider replacing with a shorter syntax:

    "@twilio/cli-core": "twilio/twilio-cli-core#5.26.1-rc",

"chalk": "^4.1.0",
"cli-ux": "^5.6.2",
"file-type": "^14.6.2",
Expand Down