Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kebab case function to handle names with digits #43

Merged
merged 3 commits into from
Jun 20, 2019

Conversation

maylonpedroso
Copy link
Contributor

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • This PR fixes how names including digits like Pascal2Case are handled when converting to kebab-case

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files          24       24           
  Lines         644      644           
=======================================
  Hits          638      638           
  Misses          6        6
Impacted Files Coverage Δ
src/services/naming-conventions.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3f51e...08efd86. Read the comment docs.

@childish-sambino childish-sambino merged commit bb9524e into twilio:master Jun 20, 2019
@maylonpedroso maylonpedroso deleted the kebab-case-with-digits branch September 18, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants