feat: add regional and edge support #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshanholtz
reviewed
May 13, 2020
eshanholtz
reviewed
May 13, 2020
| @@ -78,9 +69,9 @@ private static string UrlFromUri(Domain domain, string region, string uri) | |||
| /// <param name="domain">Twilio subdomain</param> | |||
| /// <param name="region">Twilio region</param> | |||
| /// <returns>URL for the first page of results</returns> | |||
| public string GetFirstPageUrl(Domain domain, string region) | |||
| public string GetFirstPageUrl(Domain domain, string region = null) | |||
There was a problem hiding this comment.
is this just for backwards compatibility? Don't see region being used in this func.
There was a problem hiding this comment.
Yes, it will be dropped soon but requires a yoyo change.
eshanholtz
reviewed
May 13, 2020
eshanholtz
reviewed
May 13, 2020
| public class RequestTest | ||
| { | ||
| [Test] | ||
| public void TestNoEdgeOrRegionInUrl() |
There was a problem hiding this comment.
Really like the way you organized these
eshanholtz
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.