Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change Default Logo from .ico to .png in NuGet #530

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

garethpaul
Copy link
Contributor

Fixes

On Visual Studio the current icon for twilio-csharp appears to be scrambled.

This change modifies the .ico file with .png.

Note: I wasn't entirely sure how to test this given that this is hosted with NuGet, but perhaps there is additional functionality that can be utilized for testing.

Screen Shot 2020-07-16 at 2 17 40 PM

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the master branch
  • [] I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@garethpaul garethpaul added the status: waiting for feedback waiting for feedback from the submitter label Jul 16, 2020
@garethpaul garethpaul self-assigned this Jul 16, 2020
@childish-sambino childish-sambino removed the status: waiting for feedback waiting for feedback from the submitter label Jul 17, 2020
@childish-sambino childish-sambino changed the title Change Default Logo from .ico to .png in NuGet fix: Change Default Logo from .ico to .png in NuGet Jul 17, 2020
@childish-sambino childish-sambino merged commit 078a2ae into twilio:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants