fix: allow API redirect responses

src/Twilio/Clients/TwilioRestClient.cs

@@ -146,7 +146,7 @@ private static Response ProcessResponse(Response response)
                 throw new ApiConnectionException("Connection Error: No response received.");
             }
 
-            if (response.StatusCode >= HttpStatusCode.OK && response.StatusCode < HttpStatusCode.Ambiguous)
+            if (response.StatusCode >= HttpStatusCode.OK && response.StatusCode < HttpStatusCode.BadRequest)
             {
                 return response;
             }

src/Twilio/Http/Net35/WebRequestWrappers.cs

@@ -48,6 +48,7 @@ public class HttpWebRequestWrapper : IHttpWebRequestWrapper
         public HttpWebRequestWrapper(Uri uri)
         {
             this._httpWebRequest = (HttpWebRequest) WebRequest.Create(uri);
+            this._httpWebRequest.AllowAutoRedirect=false;
         }
 
         public string UserAgent

src/Twilio/Http/SystemNetHttpClient.cs

@@ -27,7 +27,7 @@ public class SystemNetHttpClient : HttpClient
         /// <param name="httpClient">HTTP client to use</param>
         public SystemNetHttpClient(System.Net.Http.HttpClient httpClient = null)
         {
-            _httpClient = httpClient ?? new System.Net.Http.HttpClient();
+            _httpClient = httpClient ?? new System.Net.Http.HttpClient(new HttpClientHandler() { AllowAutoRedirect = false });
         }
 
         /// <summary>
@@ -94,7 +94,8 @@ private HttpRequestMessage BuildHttpRequest(Request request)
             var libraryVersion = "twilio-csharp/" + AssemblyInfomation.AssemblyInformationalVersion + PlatVersion;
             httpRequest.Headers.TryAddWithoutValidation("User-Agent", libraryVersion);
 
-            foreach (var header in request.HeaderParams) {
+            foreach (var header in request.HeaderParams)
+            {
                 httpRequest.Headers.TryAddWithoutValidation(header.Key, header.Value);
             }
 

test/Twilio.Test/Clients/TwilioRestClientTest.cs

@@ -34,15 +34,20 @@ public void TestCantConnect()
             // Exception type doesn't matter, just needs to match in IsInstanceOf below.
             client.MakeRequest(Arg.Any<Request>()).Throws(new InvalidOperationException());
 
-            try {
+            try
+            {
                 TwilioRestClient.ValidateSslCertificate(client);
                 Assert.Fail("Should have failed ssl verification");
-            } catch (CertificateValidationException e) {
+            }
+            catch (CertificateValidationException e)
+            {
                 Assert.IsInstanceOf(typeof(InvalidOperationException), e.GetBaseException());
                 Assert.AreEqual("Connection to api.twilio.com:8443 failed", e.Message);
                 Assert.IsNull(e.Response);
                 Assert.IsNotNull(e.Request);
-            } catch (Exception) {
+            }
+            catch (Exception)
+            {
                 Assert.Fail("Threw an unknown exception");
             }
         }
@@ -52,14 +57,19 @@ public void TestNotOkResponse()
         {
             client.MakeRequest(Arg.Any<Request>()).Returns(new Response(HttpStatusCode.SwitchingProtocols, "NOTOK"));
 
-            try {
+            try
+            {
                 TwilioRestClient.ValidateSslCertificate(client);
                 Assert.Fail("Should have failed ssl verification");
-            } catch (CertificateValidationException e) {
+            }
+            catch (CertificateValidationException e)
+            {
                 Assert.AreEqual("Unexpected response from certificate endpoint", e.Message);
                 Assert.IsNotNull(e.Response);
                 Assert.IsNotNull(e.Request);
-            } catch (Exception) {
+            }
+            catch (Exception)
+            {
                 Assert.Fail("Threw an unknown exception");
             }
         }
@@ -76,12 +86,15 @@ public void TestBadResponseWithDetails()
                                         ""foo"": ""bar""
                                     }}";
             client.MakeRequest(Arg.Any<Request>()).Returns(new Response(HttpStatusCode.BadRequest, jsonResponse));
-            try {
-                Request request =  new Request(HttpMethod.Get,"https://www.contoso.com");
+            try
+            {
+                Request request = new Request(HttpMethod.Get, "https://www.contoso.com");
                 TwilioRestClient twilioClient = new TwilioRestClient("foo", "bar", null, null, client);
                 twilioClient.Request(request);
                 Assert.Fail("Should have failed");
-            } catch (ApiException e) {
+            }
+            catch (ApiException e)
+            {
                 Assert.AreEqual("Bad request", e.Message);
                 Assert.AreEqual(20001, e.Code);
                 Assert.AreEqual("https://www.twilio.com/docs/errors/20001", e.MoreInfo);
@@ -91,5 +104,14 @@ public void TestBadResponseWithDetails()
                 Assert.AreEqual(expectedDetails, e.Details);
             }
         }
+
+        [Test]
+        public void TestRedirectResponse()
+        {
+            client.MakeRequest(Arg.Any<Request>()).Returns(new Response(HttpStatusCode.RedirectKeepVerb, "REDIRECT"));
+            Request request = new Request(HttpMethod.Get, "https://www.contoso.com");
+            TwilioRestClient twilioClient = new TwilioRestClient("foo", "bar", null, null, client);
+            twilioClient.Request(request);
+        }
     }
 }