Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update documentation in upgrade.md #554

Merged
merged 2 commits into from
Jan 28, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions UPGRADE.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Upgrade Guide

_After `5.0.0` all `MINOR` and `MAJOR` version bumps will have upgrade notes
posted here._
_`MAJOR` version bumps will have upgrade notes posted here._

[2017-11-XX] 5.8.x to 5.9.x
---------------------------
Expand All @@ -10,19 +9,19 @@ posted here._

#### Rationale
This was changed to add support for time-to-live to Sync objects. Users can now either provide either `data`, `ttl`, or both.
This only affects users who pass the `twilioRestClient` parameter to the _Affected Resources_ below.
This only affects users who pass the `twilioRestClient` parameter to the _Affected Resources_ below.

#### Affected Resources
- DocumentResource.Update(...)
- SyncListItemResource.Update(...)
- SyncMapItemResource.Update(...)

#### 5.8.x
```cs
using Twilio.Rest.Sync.V1.Service;
using Twilio.Rest.Sync.V1.Service.SyncList;
using Twilio.Rest.Sync.V1.Service.SyncMap;

DocumentResource.Update("IS123", "ET123", "{}", twilioRestClient);
SyncListItemResource.Update("IS123", "ES123", 1, "{}", twilioRestClient);
SyncMapItemResource.Update("IS123", "MP123", "myKey" "{}", twilioRestClient);
Expand All @@ -33,7 +32,7 @@ SyncMapItemResource.Update("IS123", "MP123", "myKey" "{}", twilioRestClient);
using Twilio.Rest.Sync.V1.Service;
using Twilio.Rest.Sync.V1.Service.SyncList;
using Twilio.Rest.Sync.V1.Service.SyncMap;

DocumentResource.Update("IS123", "ET123", "{}", null, twilioRestClient);
SyncListItemResource.Update("IS123", "ES123", 1, "{}", null, twilioRestClient);
SyncMapItemResource.Update("IS123", "MP123", "myKey" "{}", null, twilioRestClient);
Expand All @@ -56,7 +55,7 @@ Previously all TwiML resources were under the `Twilio.TwiML` namespace.
- Gather
- Moved to `Twilio.TwiML.Messaging`
- Message

#### 5.7.x
```cs
using Twilio.TwiML;
Expand Down