Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: requestValidation when hostname URL has any uppercase letters #567

Merged
merged 35 commits into from
May 29, 2021
Merged

fix: requestValidation when hostname URL has any uppercase letters #567

merged 35 commits into from
May 29, 2021

Conversation

thinkingserious
Copy link
Contributor

@thinkingserious thinkingserious commented May 20, 2021 •
edited by childish-sambino
Loading

Fixes #522

Checklist

  • I acknowledge that all my contributions will be made under the project's license

Internal Reference: DI-1369

childish-sambino
childish-sambino reviewed May 20, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
Dockerfile.dev Outdated Show resolved Hide resolved
@thinkingserious thinkingserious marked this pull request as draft May 21, 2021 22:52
@thinkingserious thinkingserious marked this pull request as ready for review May 21, 2021 23:21
@thinkingserious thinkingserious merged commit 17b1927 into main May 29, 2021
@thinkingserious thinkingserious deleted the request-validator branch May 29, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshanholtz eshanholtz eshanholtz left review comments

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RequestValidator
4 participants
@thinkingserious @eshanholtz @childish-sambino @shwetha-manvinkurke