-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add PlaybackGrant #581
Merged
shwetha-manvinkurke
merged 1 commit into
twilio:main
from
miguelgrinberg:add-playback-grant
Oct 15, 2021
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
using System.Collections.Generic; | ||
|
||
namespace Twilio.Jwt.AccessToken | ||
{ | ||
/// <summary> | ||
/// Grant to expose Twilio Live | ||
/// </summary> | ||
public class PlaybackGrant : IGrant | ||
{ | ||
/// <summary> | ||
/// Grant payload | ||
/// </summary> | ||
public Dictionary<string, object> Grant { get; set; } | ||
|
||
/// <summary> | ||
/// Get the playback grant key | ||
/// </summary> | ||
/// | ||
/// <returns>the playback grant key</returns> | ||
public string Key | ||
{ | ||
get | ||
{ | ||
return "player"; | ||
} | ||
} | ||
|
||
/// <summary> | ||
/// Get the playback grant payload | ||
/// </summary> | ||
/// | ||
/// <returns>the video grant payload</returns> | ||
public object Payload | ||
{ | ||
get | ||
{ | ||
return Grant; | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In all the tests across libraries, I haven't seen this value being set. Have you tested the token live with the credentials set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field comes like this from the playbackGrant resource. I have not seen it set to anything other than null.